税率設定時に商品別税率を考慮していないのを修正 #6117
Merged
税率設定時に商品別税率を考慮していないのを修正 #6117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 4.3 #6117 +/- ##
=========================================
Coverage 82.76% 82.76%
Complexity 6514 6514
=========================================
Files 479 479
Lines 26035 26036 +1
=========================================
+ Hits 21547 21548 +1
Misses 4488 4488
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@tatsuishi |
|
@tatsuishi |
tatsuishi
force-pushed
the
dev/fix_tax_rule_error
branch
from
05bbbdd
to
3825fa9
Compare
|
@dotani1111 |
|
@tatsuishi |
ji-eunsoo
approved these changes
Apr 2, 2024
dotani1111
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
Issue
商品別税率が設定されている場合に、基本税率を編集しようとするとエラーになる #6090
方針(Policy)
商品別税率が設定されている場合に、基本税率を編集しようとすると、
「同時刻の適用日時を設定できません。」というエラーが表示されてしまいます。
基本税率での適用日時と同じapply_dateで商品別税率が設定されている商品が存在する場合に発生していたため、修正を行いました。
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目